Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/winperfcounters] Fix wildcard handling #9240

Merged
merged 3 commits into from
Apr 12, 2022
Merged

[pkg/winperfcounters] Fix wildcard handling #9240

merged 3 commits into from
Apr 12, 2022

Conversation

Mrod1598
Copy link
Contributor

Description:

Updated package to pass multiple CounterValues out when there are multiple instances being handled.

Link to tracking Issue:
#9238

Testing:
Added a test to ensure wildcards are working

@Mrod1598 Mrod1598 requested a review from a team April 12, 2022 18:32
@Mrod1598 Mrod1598 requested a review from dashpole as a code owner April 12, 2022 18:32
djaglowski
djaglowski reviewed Apr 12, 2022
View reviewed changes
pkg/winperfcounters/watcher_test.go Outdated Show resolved Hide resolved
pkg/winperfcounters/watcher.go Outdated Show resolved Hide resolved
@Mrod1598 Mrod1598 requested a review from djaglowski April 12, 2022 20:08
djaglowski
djaglowski reviewed Apr 12, 2022
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, but you need to add a changelog entry.

@Mrod1598
Copy link
Contributor Author

Generally looks good to me, but you need to add a changelog entry.

does it need one if the original changelog adding this package isn't released yet?

@djaglowski
Copy link
Member

Fair enough.

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 12, 2022
djaglowski
djaglowski approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Mrod1598

@djaglowski djaglowski merged commit 4a76da8 into open-telemetry:main Apr 12, 2022
@Mrod1598 Mrod1598 deleted the fix-windows-perf-package branch April 13, 2022 01:02
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

Assignees

@Aneurysm9 Aneurysm9

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mrod1598 @djaglowski @Aneurysm9