-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parsing for labels and guages in statsdreceiver #903
Add parsing for labels and guages in statsdreceiver #903
Conversation
@sonofachamp is this fixing an open issue? |
@tigrannajaryan Not fixing an open issue, but expanding on the StatsD receiver support #290 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, left a couple of comments.
Also, please rebase to fix lint.
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
==========================================
+ Coverage 88.47% 88.52% +0.04%
==========================================
Files 245 245
Lines 13085 13149 +64
==========================================
+ Hits 11577 11640 +63
- Misses 1148 1149 +1
Partials 360 360
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Good to see this is merged. Thanks. |
@jmacd thanks for the input over today's discussion. As suggested, we will consider writing one histogram per point for now. Questions for aggregation:
I am more than happy to have a separate call this week to get this sorted out before our implementation. |
I chatted with sjkaris and he is currently not going to actively contribute to the Collector so he will not need the "approver" role. Removing for now and will add back when he decides to contribute to the Collector again. Thanks, sjkaris!
* Avoid applying stale udpates; add a test * Add Memory option to basic processor * Always use memory in the pull controller * Test the memory option * Precommit * Add a Prometheus-specific test * More comment on Memory option * Link to 862 * Remove sleep * Update changelog * Comment on stale and stateless aggregators * Update sdk/metric/processor/basic/config.go Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Liz Fong-Jones <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
… adding 'attributes' parameter to util function (#903) * code changes to resolve conditional server span creation for WSGI (open-telemetry/opentelemetry-python-contrib#454) * Adding entry to changelog.md * modifying _start_internal_or_server_span() to add attributes as a parameter. Also calling _start_internal_or_server_span() in WSGI instrumentation * resolving flake8 and typo issues
Description:
Add parsing for gauges and labels.
Link to tracking Issue:
#290
Testing:
Expanded unit test coverage.
Documentation: