Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests on 1.18 in addition to 1.17 #8550

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Mar 18, 2022

Description:
Run unit tests on 1.18 in addition to 1.17.

Related to open-telemetry/opentelemetry-collector#5032, but for contrib.

In order to merge this PR, an admin for the repo will need to change the branch protection rules for main to require the build-and-test / unittest (1.18) and build-and-test / unittest (1.17) checks instead of the unittest check.

@dashpole dashpole marked this pull request as ready for review March 18, 2022 22:04
@dashpole dashpole requested review from a team and anuraaga March 18, 2022 22:05
@dashpole dashpole added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 18, 2022
@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Mar 24, 2022
@mx-psi
Copy link
Member

mx-psi commented Mar 24, 2022

Marking as ready to merge since remaining steps (#8553) are to be done by a maintainer

@dashpole dashpole closed this Mar 24, 2022
@dashpole dashpole reopened this Mar 24, 2022
@dashpole
Copy link
Contributor Author

I still see unittest Expected — Waiting for status to be reported (Required) in the tests

@mx-psi
Copy link
Member

mx-psi commented Mar 24, 2022

I would say that's because the branch protection rules have not been updated yet, we need a maintainer for next steps

@codeboten
Copy link
Contributor

Sadly even a maintainer can't update branch protection :(. we need someone from the TC.

cc @bogdandrutu

@tigrannajaryan
Copy link
Member

@bogdandrutu PTAL.

I think we need to disable the unittest from protections temporarily, merge this PR and add the 2 new protections.

@tigrannajaryan tigrannajaryan merged commit 1f1d392 into open-telemetry:main Mar 25, 2022
@tigrannajaryan
Copy link
Member

unittest action removed from protections, PR merged, waiting to finish to add the new actions to protections...

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Mar 25, 2022

unittest (1.17) and unittest (1.18) actions added to protections.

@tigrannajaryan
Copy link
Member

@dashpole
Copy link
Contributor Author

Error: /home/runner/go/pkg/mod/google.golang.org/[email protected]/internal/transport/controlbuf.go:30:2: golang.org/x/[email protected]: stream error: stream ID 57; INTERNAL_ERROR; received from peer
Error: /home/runner/go/pkg/mod/google.golang.org/[email protected]/internal/transport/controlbuf.go:31:2: golang.org/x/[email protected]: stream error: stream ID 57; INTERNAL_ERROR; received from peer
Error: /home/runner/go/pkg/mod/google.golang.org/[email protected]/server.go:36:2: golang.org/x/[email protected]: stream error: stream ID 57; INTERNAL_ERROR; received from peer

Seems like it isn't able to go get grpc?

@dashpole dashpole deleted the test_1_18 branch March 25, 2022 20:24
@tigrannajaryan
Copy link
Member

Probably a transient network error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants