-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run unit tests on 1.18 in addition to 1.17 #8550
Conversation
Marking as ready to merge since remaining steps (#8553) are to be done by a maintainer |
I still see |
I would say that's because the branch protection rules have not been updated yet, we need a maintainer for next steps |
Sadly even a maintainer can't update branch protection :(. we need someone from the TC. cc @bogdandrutu |
@bogdandrutu PTAL. I think we need to disable the unittest from protections temporarily, merge this PR and add the 2 new protections. |
unittest action removed from protections, PR merged, waiting to finish to add the new actions to protections... |
unittest (1.17) and unittest (1.18) actions added to protections. |
@dashpole the build failed after merging: |
Seems like it isn't able to |
Probably a transient network error. |
Description:
Run unit tests on 1.18 in addition to 1.17.
Related to open-telemetry/opentelemetry-collector#5032, but for contrib.
In order to merge this PR, an admin for the repo will need to change the branch protection rules for main to require the
build-and-test / unittest (1.18)
andbuild-and-test / unittest (1.17)
checks instead of theunittest
check.