chore: adds vanity import check. #6305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
requested review from
alolita,
Aneurysm9,
anuraaga,
arminru,
djaglowski,
dmitryax,
jmacd,
jpkrohling,
jsuereth,
kbrockhoff,
mx-psi,
owais and
punya
as code owners
|
Ping @mx-psi @bogdandrutu |
|
needs a rebase (otherwise looks good, although there is less value here since we don't use the fancy |
|
While we don't use the fancy domain I really think the url is too long that
having this import path at hand is very useful.
|
jcchavezs
force-pushed
the
adds_vanity_import
branch
from
d4d8a7a to
ea13403
Compare
|
Rebase done. |
mx-psi
approved these changes
Nov 16, 2021
jcchavezs
force-pushed
the
adds_vanity_import
branch
from
ea13403 to
42346dc
Compare
|
Could we please merge this before I have to do another rebase? cc @bogdandrutu @carlosalberto |
codeboten
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds vanity import for all packages to easy the consumption of the library.
Follows from open-telemetry/opentelemetry-collector#4180