Migrated Google Cloud Spanner receiver to scraper approach. #5868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asukhyy
approved these changes
Oct 21, 2021
jpkrohling
reviewed
Oct 22, 2021
receiver/googlecloudspannerreceiver/internal/metadata/metricsbuilder.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudspannerreceiver/internal/metadata/metricsbuilder_test.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudspannerreceiver/internal/metadata/metricsbuilder_test.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudspannerreceiver/internal/metadata/metricsbuilder_test.go
Show resolved
Hide resolved
receiver/googlecloudspannerreceiver/internal/metadata/metricsbuilder_test.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudspannerreceiver/internal/metadata/metricsdatapoint.go
Outdated
Show resolved
Hide resolved
ydrozhdzhal
force-pushed
the
googlecloudspannerreceiver/migration-to-scraper
branch
from
8584ce8 to
07860c2
Compare
ydrozhdzhal
force-pushed
the
googlecloudspannerreceiver/migration-to-scraper
branch
from
07860c2 to
2b32a66
Compare
|
@jpkrohling , I resolved all your comments. One job failed, but it is not related to my changes (( |
|
Created #5874 to address the flaky test. Tests restarted. |
jpkrohling
approved these changes
Oct 22, 2021
jpkrohling
added
the
ready to merge
Ok |
|
@jpkrohling this time failed unit tests job with unrelated test. Can you trigger re-run for it? |
|
Issue opened (#5875) and tests restarted. |
|
@bogdandrutu , @tigrannajaryan , all approvals received. |
ydrozhdzhal
deleted the
googlecloudspannerreceiver/migration-to-scraper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent of this MR is to migrate receiver implementation to scraper approach - this also will automatically add obsreporting.
These changes were requested by @bogdandrutu in scope of #5831 MR.
FYI: @tigrannajaryan , @jpkrohling