Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating core dependency #5743

Merged
merged 36 commits into from
Oct 14, 2021

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Oct 13, 2021

This change also includes:

  • reverting TLSSetting from pointer for grpc/http config
  • update receiver code to use ReceiverCreateSettings
  • update scraperhelper to use ReceiverCreateSettings

@bogdandrutu
Copy link
Member

Please rebase, fix CI errors :)

@mx-psi
Copy link
Member

mx-psi commented Oct 14, 2021

# github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kafkametricsreceiver
receiver/kafkametricsreceiver/receiver.go:80:9: cannot use params.TelemetrySettings.Logger (type *zap.Logger) as type component.ReceiverCreateSettings in argument to scraperhelper.NewScraperControllerReceiver
# github.com/open-telemetry/opentelemetry-collector-contrib/receiver/zookeeperreceiver
receiver/zookeeperreceiver/factory.go:73:9: cannot use params.TelemetrySettings.Logger (type *zap.Logger) as type component.ReceiverCreateSettings in argument to scraperhelper.NewScraperControllerReceiver
# github.com/open-telemetry/opentelemetry-collector-contrib/receiver/wavefrontreceiver
receiver/wavefrontreceiver/factory.go:85:34: cannot use params.TelemetrySettings.Logger (type *zap.Logger) as type component.ReceiverCreateSettings in argument to carbonreceiver.New
# github.com/open-telemetry/opentelemetry-collector-contrib/receiver/hostmetricsreceiver
receiver/hostmetricsreceiver/factory.go:105:6: cannot use set.TelemetrySettings.Logger (type *zap.Logger) as type component.ReceiverCreateSettings in argument to scraperhelper.NewScraperControllerReceiver

@codeboten
Copy link
Contributor Author

# github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kafkametricsreceiver
receiver/kafkametricsreceiver/receiver.go:80:9: cannot use params.TelemetrySettings.Logger (type *zap.Logger) as type component.ReceiverCreateSettings in argument to scraperhelper.NewScraperControllerReceiver
# github.com/open-telemetry/opentelemetry-collector-contrib/receiver/zookeeperreceiver
receiver/zookeeperreceiver/factory.go:73:9: cannot use params.TelemetrySettings.Logger (type *zap.Logger) as type component.ReceiverCreateSettings in argument to scraperhelper.NewScraperControllerReceiver
# github.com/open-telemetry/opentelemetry-collector-contrib/receiver/wavefrontreceiver
receiver/wavefrontreceiver/factory.go:85:34: cannot use params.TelemetrySettings.Logger (type *zap.Logger) as type component.ReceiverCreateSettings in argument to carbonreceiver.New
# github.com/open-telemetry/opentelemetry-collector-contrib/receiver/hostmetricsreceiver
receiver/hostmetricsreceiver/factory.go:105:6: cannot use set.TelemetrySettings.Logger (type *zap.Logger) as type component.ReceiverCreateSettings in argument to scraperhelper.NewScraperControllerReceiver

Yup... still working through the changes here, will have these done sometimes today.

@codeboten codeboten force-pushed the codeboten/update-otel-oct13 branch from 832981f to 35371d8 Compare October 14, 2021 14:53
@bogdandrutu bogdandrutu merged commit ffcde7b into open-telemetry:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants