Log datapoints option #5689
Merged
Log datapoints option #5689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dloucasfx
force-pushed
the
sfx-exporter-logs
branch
from
a3297e4 to
e3eb715
Compare
|
Thanks @rmfitzpatrick for reviewing, PR is updated. |
rmfitzpatrick
approved these changes
Oct 14, 2021
Signed-off-by: Dani Louca <[email protected]>
dloucasfx
force-pushed
the
sfx-exporter-logs
branch
from
e3eb715 to
88dbd25
Compare
|
Thanks @rmfitzpatrick PR is updated with your suggestions |
|
@dloucasfx thanks for the change. For future PRs please make sure the commit message is also populated (not just a one-liner). The PR description that you have is very nice and would be great to have as a commit message (I copy/pasted it this time before merging). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dani Louca [email protected]
Description:
This PR introduces a new option
log_data_pointsto thesignalfxexporter; when set to true and the log level is set to debug, we will log datapoints coming to the signalfx exporter and all sfx datapoints that will be dispatched to SignalFX, after they got converted, translated and filtered by the exporterThis greatly helps debugging issues related to dispatched datapoints to confirm what's been sent to the backend/system.
This PR will also log filtered datapoints when log level is set to debug, independently of
log_data_points.Documentation:
log_data_points(default =false): If the log level is set todebugand this is true, all datapoints dispatched to SignalFX will be logged