Extend kafkareceiver configuration capabilities #5677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
trasc
changed the title
|
@open-telemetry/collector-approvers This component does not have codeowners. Anyone interested to be one and/or help review this PR? |
|
If we don't have volunteers by Monday, I'll take it. |
It looks like, we don't. |
jpkrohling
reviewed
Oct 12, 2021
jpkrohling
approved these changes
Oct 12, 2021
|
@tigrannajaryan, Is there something else I should do at this point? |
jpkrohling
added
the
ready to merge
Make the autocommit functionality configurable. Giving the option to disable it or change the interval.
Make the time and condition of the message marking configurable. The messages could be marked before or after they are processed by the pipeline and could depend on the processing result.
Co-authored-by: Juraci Paixão Kröhling <[email protected]>
Co-authored-by: Tigran Najaryan <[email protected]>
Co-authored-by: Tigran Najaryan <[email protected]>
trasc
force-pushed
the
extemd_kafka_rcv_conf
branch
from
836755a to
157a237
Compare
|
Can we get a rerun for the unit tests? It looks like #5726 but:
|
|
@trasc re-running... |
bogdandrutu
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Extend the kafkareceiver's configuration capabilities to be able to control the offsets autocommit and message marking strategy.
Link to tracking Issue: n/a
Testing: No regressions in local testing.
Documentation: kafkareceiver documentation was updated to reflect the changes