Introduce metricsConsumer and gaugeMetricConsumer. #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
keep94
force-pushed
the
tobs_in_progress_metrics_exporter
branch
2 times, most recently
from
f466330 to
900c332
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@oppegard @thepeterstone please review as codeowners. |
oppegard
approved these changes
Oct 5, 2021
keep94
force-pushed
the
tobs_in_progress_metrics_exporter
branch
from
c21c3de to
35089c0
Compare
bogdandrutu
approved these changes
Oct 11, 2021
anuraaga
approved these changes
Oct 12, 2021
keep94
force-pushed
the
tobs_in_progress_metrics_exporter
branch
from
35089c0 to
789ed57
Compare
|
Hi. It appears that |
keep94
force-pushed
the
tobs_in_progress_metrics_exporter
branch
from
789ed57 to
ae68125
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is the first pull request for adding a tanzu observability metrics exporter.
This PR introduces the metricsConsumer type which consumes pdata.Metrics instances by sending the metrics within to
tanzu observability.
A metricsConsumer instance is made up of multiple metricConsumer instances. Each metricConsumer instance consumes
a specific type of metric such as Gauge, Sum, or Histogram.
This PR also introduces a function that returns a metricConsumer that consumes gauge metrics.
Future PRs will introduce new implementations of metricConsumer. Each new implementation will consume a different type
of metric.
Testing:
Unit tests only. The instances that will send data to tanzu observability are interfaces. The unit tests create mock
implementations of these interfaces and verify that the right calls were made to them.