Enable cumulative to delta processor #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rayhan Hossain <[email protected]>
jmacd
approved these changes
Jul 19, 2021
a-feld
approved these changes
Jul 23, 2021
There was a problem hiding this comment.
Rayhan and I had a conversation over zoom. I think New Relic has a couple of additional requirements:
- Monotonic counter reset detection
- Default include to all cumulative metrics. Our platform doesn't currently accept cumulative metrics natively; therefore, the user story we desire is for default inclusion.
We will be submitting a follow on PR containing many of the concepts from this implementation https://github.com/a-feld/cumulativetodeltaprocessor
For now, it would be great to push this forward. Approving on behalf on New Relic. ✅
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
bogdandrutu
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rayhan Hossain [email protected]
Description:
This PR enables the new cumulative to delta processor. This is dependent on PR #4216
Issue: #3751