Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix flaky test in kafkatopicsobserver #38218

Conversation

wojtekzyla
Copy link
Contributor

@wojtekzyla wojtekzyla commented Feb 26, 2025

Description

Fixing a flaky test

Link to tracking issue

Fixes #38192

@wojtekzyla wojtekzyla requested review from MovieStoreGuy and a team as code owners February 26, 2025 11:04
@github-actions github-actions bot requested a review from dmitryax February 26, 2025 11:06
@wojtekzyla wojtekzyla force-pushed the fix/update-test-in-kafka-topic-observer branch from aac3db4 to 586a60a Compare February 26, 2025 11:09
@wojtekzyla wojtekzyla changed the title fix: fix flaky test fix: fix flaky test in kafkatopicsobserver Feb 26, 2025
@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 26, 2025
@wojtekzyla wojtekzyla force-pushed the fix/update-test-in-kafka-topic-observer branch from 6e31495 to d05de48 Compare February 26, 2025 20:15
update assertion

delete changelog entry; change assertion to require.ElementsMatch

fix: fix flaky test

update assertion

delete changelog entry
@wojtekzyla wojtekzyla force-pushed the fix/update-test-in-kafka-topic-observer branch from d05de48 to acac355 Compare February 26, 2025 20:16
@songy23
Copy link
Member

songy23 commented Feb 26, 2025

@songy23 songy23 merged commit 2098453 into open-telemetry:main Feb 26, 2025
155 of 156 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 26, 2025
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Feb 26, 2025
#### Description
Fixing a flaky test

#### Link to tracking issue
Fixes open-telemetry#38192
yiquanzhou added a commit to dash0hq/opentelemetry-collector-contrib that referenced this pull request Feb 27, 2025
* main: (22 commits)
  [receiver/awsfirehose] Add support for encoding extensions (open-telemetry#37262)
  fix(deps): update module google.golang.org/api to v0.223.0 (open-telemetry#38181)
  [chore] skip TestSyslogComplementaryRFC3164 (open-telemetry#38240)
  fix(deps): update module github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common to v1.0.1106 (open-telemetry#38199)
  [provider/s3] Use mdatagen, promote to alpha (open-telemetry#38227)
  fix: fix flaky test in kafkatopicsobserver (open-telemetry#38218)
  [processor/resourcedetection] Add k8s.cluster.uid to kubeadm detector (open-telemetry#38216)
  Revert "Add issue generation from fkaly tests for all archs (open-telemetry#38191)" (open-telemetry#38230)
  Revert "Introduce issuegenerator to open issues when tests fail on main (open-telemetry#38177)" (open-telemetry#38231)
  [chore] Update otelcol core dependency (open-telemetry#38214)
  [pkg/stanza] Improve error logs produced by transformer processors (open-telemetry#37285)
  [receiver/statsd] Make full config structure public (open-telemetry#38186)
  processor/metricsstarttime: add ridwanmsharif as codeowner (open-telemetry#38193)
  fix(deps): update module github.com/huaweicloud/huaweicloud-sdk-go-v3 to v0.1.137 (open-telemetry#38154)
  [pkg/datadog] export StaticAPIKeyCheck (open-telemetry#38223)
  [chore][pkg/ottl] Move scope and resource PathGetSetters to internal ctx packages (open-telemetry#38225)
  fix(deps): update all github.com/datadog packages to v0.64.0-rc.3 (open-telemetry#38202)
  feat(telemetrygen): added support for delta temporality (open-telemetry#38146)
  [chore] Some more fixes of component IDs (open-telemetry#38221)
  [chore][pkg/ottl] Define PathGetSetter in ctxdatapoint (open-telemetry#38201)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension/observer Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky test] [extension/observer/kafkatopicsobserver] TestCollectEndpointsAllConfigSettings is flaky
3 participants