Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extension/file_storage] Mention umask in the permissions of file_storage #37783

Merged
merged 1 commit into from
Feb 12, 2025
Merged

[extension/file_storage] Mention umask in the permissions of file_storage #37783

merged 1 commit into from
Feb 12, 2025

Conversation

cbandy
Copy link
Contributor

@cbandy cbandy commented Feb 7, 2025

Description

I was tripped up by umask while I was configuring file_storage.

Link to tracking issue

Fixes: #37774

@cbandy cbandy requested a review from a team as a code owner February 7, 2025 20:19
@cbandy cbandy requested a review from jpkrohling February 7, 2025 20:19
@cbandy cbandy mentioned this pull request Feb 7, 2025
Closed
swiatekm
swiatekm approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the update! This wasn't immediately obvious to me either, so it's worth documenting.

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 12, 2025
@djaglowski djaglowski merged commit 9b05daf into open-telemetry:main Feb 12, 2025
152 of 153 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 12, 2025
@cbandy cbandy deleted the fs-umask branch February 13, 2025 01:21
khushijain21 pushed a commit to khushijain21/opentelemetry-collector-contrib that referenced this pull request Feb 14, 2025
@cbandy @khushijain21
[extension/file_storage] Mention umask in the permissions of file_sto…
0e1651c 
…rage (open-telemetry#37783)

#### Description

I was tripped up by umask while I was configuring `file_storage`. 

#### Link to tracking issue

Fixes: open-telemetry#37774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@swiatekm swiatekm swiatekm approved these changes

@VihasMakwana VihasMakwana VihasMakwana approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@atoulme atoulme Awaiting requested review from atoulme

@dmitryax dmitryax Awaiting requested review from dmitryax

Assignees

@jpkrohling jpkrohling

Labels
extension/storage Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.120.0
Development

Successfully merging this pull request may close these issues.

[filestorage] create_directory respects umask
5 participants
@cbandy @djaglowski @swiatekm @VihasMakwana @jpkrohling