[chore] remove bash script to check codeowners, use githubgen #37779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you provide some more context as to why we don't need this check anymore? I realize it's testing githubgen's functionality, but in this case it's testing this repo's codeowners file, which is an important test to have to make sure it's formatted properly. Can't we just update the expected value so that it's not failing? Are there any other tests covering this functionality that renders this test no longer needed? |
|
this workflow covers well what this bash script covered: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/.github/workflows/check-codeowners.yaml |
songy23
approved these changes
Feb 7, 2025
bogdandrutu
approved these changes
Feb 7, 2025
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Feb 8, 2025
…elemetry#37779) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This bash script precedes githubgen. It is now outdated and can be removed in favor of githubgen moving forward. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#37757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bash script precedes githubgen. It is now outdated and can be removed in favor of githubgen moving forward.
Link to tracking issue
Fixes #37757