Remove high-cardinality attribute from AWS Container Insight metrics #37697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
commented
Feb 5, 2025
| @@ -166,8 +167,9 @@ func ConvertToOTLPMetrics(fields map[string]any, tags map[string]string, logger | |||
| if tagKey == Timestamp { | |||
| timeNs, _ := strconv.ParseUint(tagValue, 10, 64) | |||
| timestamp = pcommon.Timestamp(timeNs) | |||
There was a problem hiding this comment.
timestamp is added to the data point itself, so it still needs to be calculated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per code inspection it looks like
tagswas being used as a convenience feature to pass the timestamp when converting the metrics to OTLP. However, timestamp should not be a resource attribute due to causing high-cardinality time series.This change keeps the current usage of
tags, but, ensures that timestamp is not added as a resource attribute. Code owners should consider if later the timestamp should be passed outside thetagsmap - a change much larger than the current one.Link to tracking issue
Fixes #35861
Testing
Updated respective tests.
Documentation
Changelog added.