Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/awscontainerinsight] Add HOST_PROC env var support #37694

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Feb 4, 2025

Description

Add support to HOST_PROC env var support. At this point I'm not sure if the default should be changed or not, but, with the env var one can at least experiment with the receiver on different images.

Link to tracking issue

Fixes #35862

Testing

Added respective unit test.

Documentation

Changelog

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes look good to me and align to the use of this env variable as recommended by gopsutil.

Copy link
Contributor

@pxaws pxaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax merged commit 19a5f29 into open-telemetry:main Feb 13, 2025
174 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 13, 2025
khushijain21 pushed a commit to khushijain21/opentelemetry-collector-contrib that referenced this pull request Feb 14, 2025
…lemetry#37694)

#### Description
Add support to HOST_PROC env var support. At this point I'm not sure if
the default should be changed or not, but, with the env var one can at
least experiment with the receiver on different images.

#### Link to tracking issue
Fixes open-telemetry#35862

#### Testing
Added respective unit test.

#### Documentation
Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants