-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/awscontainerinsight] Add HOST_PROC env var support #37694
Merged
dmitryax
merged 4 commits into
open-telemetry:main
from
pjanotti:fix-host-proc-env-var-support-for-awscontainerinsightreceiver
Feb 13, 2025
Merged
[receiver/awscontainerinsight] Add HOST_PROC env var support #37694
dmitryax
merged 4 commits into
open-telemetry:main
from
pjanotti:fix-host-proc-env-var-support-for-awscontainerinsightreceiver
Feb 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erinsightreceiver
atoulme
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those changes look good to me and align to the use of this env variable as recommended by gopsutil.
samiura
approved these changes
Feb 5, 2025
dmitryax
approved these changes
Feb 12, 2025
pxaws
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
khushijain21
pushed a commit
to khushijain21/opentelemetry-collector-contrib
that referenced
this pull request
Feb 14, 2025
…lemetry#37694) #### Description Add support to HOST_PROC env var support. At this point I'm not sure if the default should be changed or not, but, with the env var one can at least experiment with the receiver on different images. #### Link to tracking issue Fixes open-telemetry#35862 #### Testing Added respective unit test. #### Documentation Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to HOST_PROC env var support. At this point I'm not sure if the default should be changed or not, but, with the env var one can at least experiment with the receiver on different images.
Link to tracking issue
Fixes #35862
Testing
Added respective unit test.
Documentation
Changelog