Fixes issues related to TLS #37675
Open
Fixes issues related to TLS #37675
+112
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonalgaud12
changed the title
crobert-1
reviewed
Feb 4, 2025
jamesmoessis
reviewed
Feb 4, 2025
jamesmoessis
reviewed
Feb 4, 2025
| TLS struct { | ||
| Enabled bool `mapstructure:"enabled"` | ||
| CAFile string `mapstructure:"ca_file"` | ||
| CertFile string `mapstructure:"cert_file"` |
There was a problem hiding this comment.
Any new config fields should be covered by tests in config_test.go which uses config under testdata directory.
Ideally, there's also a new test in receiver_test.go that ensures TLS works
jamesmoessis
reviewed
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue where TLS settings were not being applied correctly for Unix socket connections to a containerd daemon. The HTTP connection layer was assuming the connection was over HTTP, causing malformed responses. This change correctly applies the TLS configuration and ensures secure connections.
Link to tracking issue
Fixes #33557