Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/redaction] introduce allowed_values parameter in processor config #37638

Merged
merged 6 commits into from
Feb 11, 2025

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Feb 3, 2025

Description

Introduce allowed_values parameter to the processor config.

If the value of an allowed key matches the regular expression for an allowed value, the matching
part of the value is not masked even if it matches the regular expression for a blocked value.

Link to tracking issue

Fixes #35840

@github-actions github-actions bot added the processor/redaction Redaction processor label Feb 3, 2025
@odubajDT odubajDT force-pushed the redaction-allowed-values branch from 376fd69 to 6cee4cf Compare February 3, 2025 09:47
@odubajDT odubajDT changed the title [processor/redaction] introduce allowed_values parameter [processor/redaction] introduce allowed_values parameter Feb 3, 2025
@odubajDT odubajDT changed the title [processor/redaction] introduce allowed_values parameter [processor/redaction] introduce allowed_values parameter in processor config Feb 3, 2025
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT marked this pull request as ready for review February 3, 2025 10:42
@odubajDT odubajDT requested a review from a team as a code owner February 3, 2025 10:42
@mx-psi mx-psi merged commit 2e98573 into open-telemetry:main Feb 11, 2025
163 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 11, 2025
yiquanzhou added a commit to dash0hq/opentelemetry-collector-contrib that referenced this pull request Feb 11, 2025
* main: (76 commits)
  Update All OpenTelemetry Collector Contrib packages (open-telemetry#37839)
  [chore] fix codeowners allowlist (open-telemetry#37856)
  Update module github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp to v1.26.0 (open-telemetry#37841)
  Update module github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common to v1.0.1095 (open-telemetry#37825)
  Update module github.com/grpc-ecosystem/grpc-gateway/v2 to v2.26.1 (open-telemetry#37821)
  [chore][exporter/elasticsearch] Bump go-docappender to v2.5.0 (open-telemetry#37852)
  Update All github.com/aws packages (open-telemetry#37816)
  Update module google.golang.org/protobuf to v1.36.5 (open-telemetry#37827)
  Update module github.com/SAP/go-hdb to v1.12.12 (open-telemetry#37817)
  Update module github.com/huaweicloud/huaweicloud-sdk-go-v3 to v0.1.135 (open-telemetry#37822)
  Update module github.com/ClickHouse/clickhouse-go/v2 to v2.31.0 (open-telemetry#37835)
  [receiver/datadog] Implement support for span links (open-telemetry#37449)
  receiver/prometheusreceiver: allow cumulative resets when using the adjuster (open-telemetry#37718)
  Update README.md (open-telemetry#37826)
  [receiver/github] add workflow run event trace handling (open-telemetry#37578)
  Update All github.com/datadog packages to v0.62.2 (open-telemetry#37838)
  [chore] Update types used in extensiontest.NewNopSettingsWithType (open-telemetry#37844)
  [processor/redaction] introduce `allowed_values` parameter in processor config (open-telemetry#37638)
  [chore] Update otel version (open-telemetry#37808)
  [testbed] Include CPU and memory limits to benchmark results file (open-telemetry#36753)
  ...
khushijain21 pushed a commit to khushijain21/opentelemetry-collector-contrib that referenced this pull request Feb 14, 2025
…or config (open-telemetry#37638)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Introduce `allowed_values` parameter to the processor config.

If the value of an allowed key matches the regular expression for an
allowed value, the matching
part of the value is not masked even if it matches the regular
expression for a blocked value.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#35840

---------

Signed-off-by: odubajDT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/redaction Redaction processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[processor/redaction] Add support for allowed values that are never redacted
4 participants