[chore] switch over githubgen to the one built with our tools #37397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
approved these changes
Jan 21, 2025
songy23
approved these changes
Jan 22, 2025
douglascamata
added a commit
to douglascamata/opentelemetry-collector-contrib
that referenced
this pull request
Jan 22, 2025
andrzej-stencel
pushed a commit
that referenced
this pull request
Jan 22, 2025
…ols (#37409) Reverts #37397. PRs started to fail after #37397 got merged because of the codeowners check action, because it runs `make githubgen-install` then calls the `githubgen` tool. I tried first fixing the CI check to run the new tool and it's giving errors, which is already starting to affect new PRs and old ones that get rebased: ``` /Users/douglas/code/opentelemetry-collector-contrib/.tools/githubgen 2025/01/22 11:43:55 codeowners are not members: Erog38, Frapschen, IbraheemA, JonathanWamsley, MovieStoreGuy, Mrod1598, NassimBtk, RichieSams, StefanKurek, VihasMakwana, adrielp, ag-ramachandran, akats7, alexvanboxel, ankitpa tel96, antonblock, armstrmi, atingchen, atoulme, avadhut123pisal, bertysentry, braydonk, bryan-aguilar, carsonip, chan-tim-sumo, chrroberts-pure, codeboten, cparkins, cpheps, dashpole, dehaansa, dgoscn, edmocosta, eedorenko, erichsueh3, evan-bradley, fatsheep9146, fchikwekwe, gjanco, greatestusername, hughesjj, jacobmarble, jade-guiton-dd, jamesmoessis, jaronoff97, jmacd, joker-star-l, jsuereth, kasia-kujawa, khyatigandhi6, kongluoxing, liustanle y, lquerel, mapno, mar4uk, marctc, martin-majlis-s1, mcardy, michalpristas, moh-osman3, mrsillydog, narcis96, nslaughter, pavankrish123, pcwiese, pjanotti, portertech, povilasv, psx95, pxaws, qiansheng91, rapphil, rnishtala-s umo, rogercoll, samiura, schmikei, shabicheng, shalper2, sinkingpoint, smithclay, splunkericl, srprash, swiatekm, tamir-michaeli, tomaz-s1, wangzlei, yotamloe, zdaratom-s1 make: *** [gengithub] Error 1 ``` I suggest that the new tool is introduced more gradually and is not used in CI yet until it behaves exactly like the old one.
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…elemetry#37397) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Change the githubgen we use to the one defined in opentelemetry-go-build-tools <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue See open-telemetry#37294
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…ols (open-telemetry#37409) Reverts open-telemetry#37397. PRs started to fail after open-telemetry#37397 got merged because of the codeowners check action, because it runs `make githubgen-install` then calls the `githubgen` tool. I tried first fixing the CI check to run the new tool and it's giving errors, which is already starting to affect new PRs and old ones that get rebased: ``` /Users/douglas/code/opentelemetry-collector-contrib/.tools/githubgen 2025/01/22 11:43:55 codeowners are not members: Erog38, Frapschen, IbraheemA, JonathanWamsley, MovieStoreGuy, Mrod1598, NassimBtk, RichieSams, StefanKurek, VihasMakwana, adrielp, ag-ramachandran, akats7, alexvanboxel, ankitpa tel96, antonblock, armstrmi, atingchen, atoulme, avadhut123pisal, bertysentry, braydonk, bryan-aguilar, carsonip, chan-tim-sumo, chrroberts-pure, codeboten, cparkins, cpheps, dashpole, dehaansa, dgoscn, edmocosta, eedorenko, erichsueh3, evan-bradley, fatsheep9146, fchikwekwe, gjanco, greatestusername, hughesjj, jacobmarble, jade-guiton-dd, jamesmoessis, jaronoff97, jmacd, joker-star-l, jsuereth, kasia-kujawa, khyatigandhi6, kongluoxing, liustanle y, lquerel, mapno, mar4uk, marctc, martin-majlis-s1, mcardy, michalpristas, moh-osman3, mrsillydog, narcis96, nslaughter, pavankrish123, pcwiese, pjanotti, portertech, povilasv, psx95, pxaws, qiansheng91, rapphil, rnishtala-s umo, rogercoll, samiura, schmikei, shabicheng, shalper2, sinkingpoint, smithclay, splunkericl, srprash, swiatekm, tamir-michaeli, tomaz-s1, wangzlei, yotamloe, zdaratom-s1 make: *** [gengithub] Error 1 ``` I suggest that the new tool is introduced more gradually and is not used in CI yet until it behaves exactly like the old one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the githubgen we use to the one defined in opentelemetry-go-build-tools
Link to tracking issue
See #37294