[exporter/signalfx] Prioritize token from context in exporter #37276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asreehari-splunk
requested review from
dmitryax,
crobert-1 and
a team
as code owners
asreehari-splunk
force-pushed
the
OTL-3132/PrioritizeTokenFromContextSignalFxExporter
branch
from
2324faa to
aed0865
Compare
dmitryax
approved these changes
Jan 16, 2025
dmitryax
changed the title
asreehari-splunk
force-pushed
the
OTL-3132/PrioritizeTokenFromContextSignalFxExporter
branch
from
aed0865 to
e3bdbaf
Compare
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…elemetry#37276) #### Description In preparation for deprecating access_token_passthrough from the signalfx receiver and exporter, update the signalfx exporter to taken accessToken from the context Testing Updated unit tests tested end to end with the following setup telemetrygen sending metrics in otlp over grpc with X-Sf-Token header and token otlp receiver with include_metadata set to true batch processor using the X-Sf-Token key to group access_token_passthrough set to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for deprecating access_token_passthrough from the signalfx receiver and exporter, update the signalfx exporter to taken accessToken from the context
Testing
Updated unit tests
tested end to end with the following setup
telemetrygen sending metrics in otlp over grpc with X-Sf-Token header and token
otlp receiver with include_metadata set to true
batch processor using the X-Sf-Token key to group
access_token_passthrough set to true