feat(googlecloudmonitoring): support monitoring filters #37264
Conversation
chenlujjj
requested review from
dashpole,
TylerHelmuth and
a team
as code owners
chenlujjj
force-pushed
the
feat-googlecloudmonitoring-filter
branch
from
1cc5e3f to
81dff4e
Compare
chenlujjj
changed the title
chenlujjj
force-pushed
the
feat-googlecloudmonitoring-filter
branch
2 times, most recently
from
31522d0 to
6fd50f2
Compare
|
|
||
| One of `metric_name` and `monitoring_filter` MUST be specified, but should not be specified at the same time. |
There was a problem hiding this comment.
Based on https://cloud.google.com/monitoring/api/v3/filters, if we are applying these to only to ListMetricDescriptor, there are a lot of restrictions on what you can filter by that might confuse users. They can't use resource or group selectors, and presumably can't filter on labels: metric.labels.instance_name = monitoring.regex.full_match("gke-(hipster|nginx).*").
One solution would be to make this a metric_descriptor_filter config option, so that it is clear we are filtering metric descriptors (and we should also document that there are restrictions on that filter). That way we could later add a separate time_series_filter that we add to actual ListTimeSeries queries if we want.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Apologize for the delay, I've been on leave in the past week. I'll continue to work on this. |
chenlujjj
force-pushed
the
feat-googlecloudmonitoring-filter
branch
2 times, most recently
from
cc43b06 to
2924022
Compare
chenlujjj
force-pushed
the
feat-googlecloudmonitoring-filter
branch
from
2924022 to
7aa0804
Compare
dashpole
added
the
ready to merge
…ry#37264) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes part of open-telemetry#36898 <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
Description
Link to tracking issue
Fixes part of #36898
Testing
Documentation