Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[elasticsearchexporter] Declare MutatesData: false #37234

Merged
merged 3 commits into from
Jan 21, 2025
Merged

[elasticsearchexporter] Declare MutatesData: false #37234

merged 3 commits into from
Jan 21, 2025

Conversation

felixbarny
Copy link
Contributor

Reduces allocations as the collector doesn't need to clone the incoming data

Description

Link to tracking issue

Fixes

Testing

Documentation

@felixbarny
Declare MutatesData: false
90caf37 
Reduces allocations as the collector doesn't need to clone the incoming data
@felixbarny felixbarny requested a review from a team as a code owner January 15, 2025 08:31
@felixbarny felixbarny requested a review from ChrsMark January 15, 2025 08:31
@ChrsMark ChrsMark added the ready to merge Code review completed; ready to merge by maintainers label Jan 21, 2025
@songy23 songy23 merged commit afbb05f into open-telemetry:main Jan 21, 2025
175 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 21, 2025
@felixbarny felixbarny deleted the es-mutates-data-false branch January 22, 2025 07:51
@mauri870 mauri870 mentioned this pull request Jan 22, 2025
Merged
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Jan 26, 2025
@felixbarny @chengchuanpeng
[elasticsearchexporter] Declare MutatesData: false (open-telemetry#37234
4d5765d 
)

Reduces allocations as the collector doesn't need to clone the incoming
data

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

@carsonip carsonip carsonip approved these changes

@JaredTan95 JaredTan95 Awaiting requested review from JaredTan95

@lahsivjar lahsivjar Awaiting requested review from lahsivjar

Assignees

@crobert-1 crobert-1

Labels
exporter/elasticsearch ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
v0.118.0
Development

Successfully merging this pull request may close these issues.
5 participants
@felixbarny @carsonip @ChrsMark @songy23 @crobert-1