Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/mongodbreceiver] Added new mongodb metrics to achieve parity with Telegraf #37227

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

chan-tim-sumo
Copy link
Contributor

@chan-tim-sumo chan-tim-sumo commented Jan 14, 2025

Description

  mongodb.queries_per_sec
  mongodb.inserts_per_sec
  mongodb.commands_per_sec
  mongodb.getmores_per_sec
  mongodb.deletes_per_sec
  mongodb.updates_per_sec
  mongodb.flushes_per_sec
  mongodb.active.writes
  mongodb.active.reads
  mongodb.wtcache.bytes.read
  mongodb.cache.dirty.percent
  mongodb.cache.used.percent
  mongodb.page_faults

Link to tracking issue

Testing

Screenshot examples:

Documentation

@chan-tim-sumo chan-tim-sumo requested a review from a team as a code owner January 14, 2025 20:18
@github-actions github-actions bot requested a review from schmikei January 14, 2025 20:19
@chan-tim-sumo chan-tim-sumo force-pushed the chan-tim_mongodbMetrics branch 2 times, most recently from 7a46972 to fcd84f3 Compare January 14, 2025 20:44
@chan-tim-sumo chan-tim-sumo force-pushed the chan-tim_mongodbMetrics branch from cb0771b to 9c33d36 Compare January 14, 2025 20:46
@chan-tim-sumo
Copy link
Contributor Author

actively fixing the build errors and merge conflicts :)

@chan-tim-sumo
Copy link
Contributor Author

chan-tim-sumo commented Jan 16, 2025

only failing check is lychee:

# Summary

| Status        | Count |
|---------------|-------|
| 🔍 Total      | 0     |
| ✅ Successful | 0     |
| ⏳ Timeouts   | 0     |
| 🔀 Redirected | 0     |
| 👻 Excluded   | 0     |
| ❓ Unknown    | 0     |
| 🚫 Errors     | 0     |
No links were found. This usually indicates a configuration error.
If this was expected, set 'failIfEmpty: false' in the args.

not really sure how to fix this, doesn't seem like anything is wrong? this check isn't required to pass to merge this PR.

@atoulme atoulme changed the title [receiver/mongodbreceiver] Added new mongodb metrics to acheive parity with Telegraf [receiver/mongodbreceiver] Added new mongodb metrics to achieve parity with Telegraf Jan 17, 2025
@chan-tim-sumo chan-tim-sumo force-pushed the chan-tim_mongodbMetrics branch from 40268c7 to 4531088 Compare January 27, 2025 19:21
@chan-tim-sumo
Copy link
Contributor Author

@atoulme moved replica metrics + routing logic to separate PR :)

#37517

@chan-tim-sumo
Copy link
Contributor Author

chan-tim-sumo commented Jan 28, 2025

@schmikei saw that you're the code owner for this repo. can you take a look when you're free?

as well as a 2nd pr related to this (broken into 2 parts): #37517

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants