[receiver/jaegerreceiver] Add logs when the respective server starts in jaegerreceiver #36961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saumyacodes-40 <[email protected]>
Saumya40-codes
commented
Dec 26, 2024
yurishkuro
reviewed
Dec 26, 2024
yurishkuro
reviewed
Dec 26, 2024
yurishkuro
reviewed
Dec 26, 2024
Signed-off-by: Saumyacodes-40 <[email protected]>
|
please include a sample output of running a collector with jaeger receiver enabled (with all its transports) to show logs in action |
I've added the same in the PR description. Should anything be changed? |
Saumya40-codes
commented
Dec 27, 2024
|
nothing looks odd to you in the output? Why do you need to repeat |
Signed-off-by: Saumyacodes-40 <[email protected]>
Apologies, I overlooked there and didnt identify that it's been updated/added by default. |
yurishkuro
reviewed
Dec 27, 2024
yurishkuro
approved these changes
Dec 27, 2024
Signed-off-by: Saumyacodes-40 <[email protected]>
|
need to run |
Signed-off-by: Saumyacodes-40 <[email protected]>
atoulme
approved these changes
Dec 30, 2024
fatsheep9146
approved these changes
Jan 18, 2025
fatsheep9146
added
the
ready to merge
Signed-off-by: Saumyacodes-40 <[email protected]>
|
build failed |
songy23
removed
the
ready to merge
👍 Updated now. |
Signed-off-by: Saumyacodes-40 <[email protected]>
Signed-off-by: Saumyacodes-40 <[email protected]>
|
Thanks @Saumya40-codes |
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…in jaegerreceiver (open-telemetry#36961) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description - This PR adds the logging related to the server starting under the [jaegerreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/jaegerreceiver) - Added logs when: GRPC, Thrift Http, Thrift Binary and Thrift compact server starts <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes jaegertracing/jaeger#6412 #### How was change tested? Running collector with `jaegerreceiver` enabled with its all transports #### Output ``` @Saumya40-codes ➜ /workspaces/opentelemetry-collector-contrib (log-endpoints) $ ./bin/otelcontribcol_linux_amd64 --config config.yaml 2024-12-27T15:37:23.428Z info [email protected]/service.go:164 Setting up own telemetry... 2024-12-27T15:37:23.428Z info telemetry/metrics.go:70 Serving metrics {"address": "localhost:8888", "metrics level": "Normal"} 2024-12-27T15:37:23.428Z info builders/builders.go:26 Development component. May change in the future. {"kind": "exporter", "data_type": "traces", "name": "debug"} 2024-12-27T15:37:23.436Z info [email protected]/service.go:230 Starting otelcontribcol... {"Version": "0.116.0-dev", "NumCPU": 2} 2024-12-27T15:37:23.436Z info extensions/extensions.go:39 Starting extensions... 2024-12-27T15:37:23.436Z info [email protected]/trace_receiver.go:252 Starting UDP server for Binary Thrift {"kind": "receiver", "name": "jaeger", "data_type": "traces", "endpoint": "0.0.0.0:6831"} 2024-12-27T15:37:23.436Z info [email protected]/trace_receiver.go:274 Starting UDP server for Compact Thrift {"kind": "receiver", "name": "jaeger", "data_type": "traces", "endpoint": "0.0.0.0:6832"} 2024-12-27T15:37:23.436Z info [email protected]/trace_receiver.go:398 Starting HTTP server for Jaeger Collector {"kind": "receiver", "name": "jaeger", "data_type": "traces", "endpoint": "0.0.0.0:14268"} 2024-12-27T15:37:23.436Z info [email protected]/trace_receiver.go:423 Starting gRPC server for Jaeger Collector {"kind": "receiver", "name": "jaeger", "data_type": "traces", "endpoint": "0.0.0.0:14250"} 2024-12-27T15:37:23.436Z info [email protected]/service.go:253 Everything is ready. Begin running and processing data. ``` #### config file used ``` receivers: jaeger: protocols: grpc: endpoint: "0.0.0.0:14250" thrift_http: endpoint: "0.0.0.0:14268" thrift_binary: endpoint: "0.0.0.0:6831" thrift_compact: endpoint: "0.0.0.0:6832" exporters: debug: {} service: pipelines: traces: receivers: [jaeger] exporters: [debug] ``` cc @fatsheep9146 --------- Signed-off-by: Saumyacodes-40 <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes jaegertracing/jaeger#6412
How was change tested?
Running collector with
jaegerreceiverenabled with its all transportsOutput
config file used
cc @fatsheep9146