Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Do not call AddScraper with nil Scraper #36343

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

bogdandrutu
Copy link
Member

No description provided.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM. I'm curious if there is another change you need this for?

@songy23
Copy link
Member

songy23 commented Nov 12, 2024

this is needed to unblock open-telemetry/opentelemetry-collector#11659 afais

@bogdandrutu bogdandrutu merged commit c0c6bca into open-telemetry:main Nov 13, 2024
159 checks passed
@bogdandrutu bogdandrutu deleted the kafkametricsreceiver branch November 13, 2024 00:05
@github-actions github-actions bot added this to the next release milestone Nov 13, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants