Update references to newly-deprecated exporterhelper.Timeout/QueueSettings #35158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/githubgen
cmd/opampsupervisor
cmd/otelcontribcol
jade-guiton-dd
requested review from
djaglowski,
MovieStoreGuy,
andrzej-stencel,
crobert-1,
dashpole,
atoulme,
jmacd,
dmitryax,
codeboten,
fatsheep9146,
jpkrohling,
TylerHelmuth,
yurishkuro,
mx-psi,
bogdandrutu,
evan-bradley,
songy23,
tigrannajaryan,
mwear,
jsuereth and
bryan-aguilar
as code owners
mx-psi
approved these changes
Sep 13, 2024
songy23
approved these changes
Sep 13, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…tings (open-telemetry#35158) **Description:** `TimeoutSettings` and `QueueSettings` in the `exporterhelper` core collector package were renamed to `TimeoutConfig` and `QueueConfig` for naming consistency reasons, and the related `NewDefault` functions were renamed as well. This PR updates the core libraries to a prerelease version with those changes, and updates opentelemetry-collector-contrib modules to the new names, to plan for the deprecation of the old names in v0.110.0. **Link to tracking Issue:** Related to [this PR](open-telemetry/opentelemetry-collector#11132) and [this issue](open-telemetry/opentelemetry-collector#6767) on the core collector. **Notes:** - `go.opentelemetry.io/collector/cmd/mdatagen` is specifically *not* updated, as it currently has a bug causing a CI test failure. - The `prometheus-compliance-tests` CI failure is unrelated to this PR.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
TimeoutSettingsandQueueSettingsin theexporterhelpercore collector package were renamed toTimeoutConfigandQueueConfigfor naming consistency reasons, and the relatedNewDefaultfunctions were renamed as well. This PR updates the core libraries to a prerelease version with those changes, and updates opentelemetry-collector-contrib modules to the new names, to plan for the deprecation of the old names in v0.110.0.Link to tracking Issue:
Related to this PR and this issue on the core collector.
Notes:
go.opentelemetry.io/collector/cmd/mdatagenis specifically not updated, as it currently has a bug causing a CI test failure.prometheus-compliance-testsCI failure is unrelated to this PR.