Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/awscloudwatch] allow named groups with no stream spec #32346

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

mikel-jason
Copy link
Contributor

Description: Allow receiving named loggroups without stream filtering as indicated by a given example linked in the README

Link to tracking Issue: #32345

Testing: Adds additional unit test for this specific config case.

Documentation: None, implementation matches the given docs/example which was not the case before

@mikel-jason mikel-jason requested a review from djaglowski as a code owner April 12, 2024 09:08
@mikel-jason mikel-jason requested a review from a team April 12, 2024 09:08
@github-actions github-actions bot requested a review from schmikei April 12, 2024 09:08
@mikel-jason mikel-jason changed the title fix(awscloudwatchreceiver): allow named groups with no stream spec [receiver/awscloudwatch] allow named groups with no stream spec Apr 12, 2024
@schmikei
Copy link
Contributor

Seems reasonable to me if CI passes

could you add a bug_fix changelog entry to your PR following the guidelines in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-a-changelog-entry

@mikel-jason
Copy link
Contributor Author

I added the changelog file and ran make and make fmt successfully. I kindly request workflow approval to get CI results. Thanks!

@mikel-jason
Copy link
Contributor Author

Only one check failing:

debug - 2024-04-15 14:27:53,319 -- Commit creating result --- {"result": "RequestResult(error=RequestError(code='HTTP Error 429', params={}, description='{\"detail\":\"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 1782 seconds.\"}'), warnings=[], status_code=429, text='{\"detail\":\"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 1782 seconds.\"}')"}
error - 2024-04-15 14:27:53,319 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 1782 seconds."}

So I have to retry every now and then until I'm not rate-limited anymore? I have no permission to retry only this specific check, the button is hidden for me.

@mikel-jason
Copy link
Contributor Author

Ok, so I cannot rebase and have the checks run again. Can someone with enough permissions take it away from here, please?

@mikel-jason
Copy link
Contributor Author

Again, failure of the pipeline. One test (and a subsequent one) failing. This one succeeded first time and the failing one from last time is ok now.

unittest-matrix (1.21.9, ubuntu-latest, cmd-0)
Failed to CreateArtifact: Failed to make request after 5 attempts: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact

At this point, I don't know how to proceed here. I guess maintainers have to re-trigger the failing parts until everything succeeds? Please advise

@djaglowski djaglowski merged commit c542a03 into open-telemetry:main Apr 18, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants