-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/awscloudwatch] allow named groups with no stream spec #32346
Conversation
Seems reasonable to me if CI passes could you add a bug_fix changelog entry to your PR following the guidelines in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-a-changelog-entry |
I added the changelog file and ran |
Only one check failing:
So I have to retry every now and then until I'm not rate-limited anymore? I have no permission to retry only this specific check, the button is hidden for me. |
Ok, so I cannot rebase and have the checks run again. Can someone with enough permissions take it away from here, please? |
Again, failure of the pipeline. One test (and a subsequent one) failing. This one succeeded first time and the failing one from last time is ok now.
At this point, I don't know how to proceed here. I guess maintainers have to re-trigger the failing parts until everything succeeds? Please advise |
Description: Allow receiving named loggroups without stream filtering as indicated by a given example linked in the README
Link to tracking Issue: #32345
Testing: Adds additional unit test for this specific config case.
Documentation: None, implementation matches the given docs/example which was not the case before