otlpjsonfilereceiver: add a replay_file config option to support heartbeats #31534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a changelog. Do you mean to use the PollInterval setting to set the replay interval? |
ridwanmsharif
force-pushed
the
ridwanmsharif/replay
branch
from
9ffb51b to
6fb5853
Compare
Yes, |
ridwanmsharif
force-pushed
the
ridwanmsharif/replay
branch
from
6fb5853 to
25ac8d8
Compare
djaglowski
reviewed
Mar 4, 2024
This was referenced Mar 5, 2024
ridwanmsharif
force-pushed
the
ridwanmsharif/replay
branch
from
25ac8d8 to
d87a14c
Compare
ridwanmsharif
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
ridwanmsharif
force-pushed
the
ridwanmsharif/replay
branch
2 times, most recently
from
98ad43d to
ccf8920
Compare
djaglowski
reviewed
Apr 18, 2024
|
Code looks good to me generally, just some CI failures to address |
ridwanmsharif
force-pushed
the
ridwanmsharif/replay
branch
from
ccf8920 to
5c63328
Compare
This change adds a config option to allow users to replay static telemetry at an interval (poll_interval is the configurable interval). This is useful for some usecases like: - Sending a heartbeat log to a logging backend, as a signal that the logging agent is alive - Sending static metadata as metrics to metrics backend. The metadata can be read using the `otlpjsonfilereceiver` that uses this package and config. Signed-off-by: Ridwan Sharif <[email protected]>
… instead This change does the following: - Removes the replay_file option from the filecononsumer config, in favor of a build option - When no tracking is used, we don't keep track of known or previously polled files. Instead reading only currently polled files that fit the pattern - Adds tests
ridwanmsharif
force-pushed
the
ridwanmsharif/replay
branch
2 times, most recently
from
e486da7 to
9e73ca3
Compare
Signed-off-by: Ridwan Sharif <[email protected]>
ridwanmsharif
force-pushed
the
ridwanmsharif/replay
branch
from
9e73ca3 to
7f1a749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change adds a config option to allow users to replay static telemetry at an interval (poll_interval is the configurable interval).
This is useful for some usecases like:
otlpjsonfilereceiverthat uses this package and config.Link to tracking Issue:
#31533
Testing:
otlpjsonfilereceiverDocumentation: