[chore][pkg/stanza] Fix lint on Windows #30339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
commented
Jan 9, 2024
| } | ||
|
|
||
| // On windows, we close files immediately after reading becauase they cannot be moved while open. | ||
| // On windows, we close files immediately after reading because they cannot be moved while open. |
There was a problem hiding this comment.
I'm questioning the quality of the current misspell used during build: I spotted this typo while changing the code near by, this was not flagged by misspell.
djaglowski
approved these changes
Jan 9, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
**Description:** Fixing lint issues when GOOS=windows. This is in preparation to eventually include lint with GOOS=windows as part of CI. **Link to tracking Issue:** N/A **Testing:** `make` on component folder on a Windows box **Documentation:** N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing lint issues when GOOS=windows. This is in preparation to eventually include lint with GOOS=windows as part of CI.
Link to tracking Issue:
N/A
Testing:
makeon component folder on a Windows boxDocumentation:
N/A