[chore] testbed: re-add missing names in perfTestDataProvider metrics #29893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
andrzej-stencel
added
the
Skip Changelog
andrzej-stencel
approved these changes
Jan 2, 2024
Also no longer skipping carbon test with failures caused by empty names
rmfitzpatrick
force-pushed
the
readdsetnamemetricdataprovider
branch
from
7869fed to
94ce5bd
Compare
atoulme
approved these changes
Jan 3, 2024
crobert-1
approved these changes
Jan 3, 2024
andrzej-stencel
added
the
ready to merge
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…open-telemetry#29893) **Description:** These changes add back names to metrics generated by the `perfTestDataProvider` that were mistakenly removed with open-telemetry@063a71a. They also include no longer skipping a carbon test with failures [caused by empty names](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/ed85d1416292601f78b8310601ec556dd6df0a6c/exporter/carbonexporter/metricdata_to_plaintext.go#L84). Co-authored-by: Andrzej Stencel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
These changes add back names to metrics generated by the
perfTestDataProviderthat were mistakenly removed with 063a71a. They also include no longer skipping a carbon test with failures caused by empty names.