Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][cmd/configschema] Fix and re-enable resolver tests on Windows #29343

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

pjanotti
Copy link
Contributor

Description:
Part 3 of #28679 these tests needed some fixes, related to file paths, to be re-enabled on Windows.

Link to tracking Issue:
Related to #28679

Testing:
Local test run on Windows for the affected packages.

Documentation:
N/A

@pjanotti pjanotti requested a review from a team November 19, 2023 18:34
@github-actions github-actions bot added the cmd/configschema configschema command label Nov 19, 2023
@pjanotti pjanotti changed the title [chorus][cmd/configschema] Fix and re-enable resolver tests on Windows [chore][cmd/configschema] Fix and re-enable resolver tests on Windows Nov 19, 2023
@pjanotti
Copy link
Contributor Author

Hit #27845 on Ubuntu #27845 (comment) not related to the current change.

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 20, 2023
@mx-psi mx-psi merged commit 38db557 into open-telemetry:main Nov 20, 2023
89 of 90 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 20, 2023
@pjanotti pjanotti deleted the part-03-of-issue-28679 branch November 21, 2023 14:02
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
…open-telemetry#29343)

**Description:**
Part 3 of open-telemetry#28679 these tests needed some fixes, related to file paths,
to be re-enabled on Windows.

**Link to tracking Issue:**
Related to open-telemetry#28679

**Testing:**
Local test run on Windows for the affected packages.

**Documentation:**
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants