Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/telemetrygen] Remove remaining replace statement #28565

Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 24, 2023

Description: #27878 was not enough to fix go install, this should fix it.

Link to tracking Issue: Fixes #27855

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 24, 2023
@github-actions github-actions bot added the cmd/telemetrygen telemetrygen command label Oct 24, 2023
@github-actions github-actions bot requested a review from codeboten October 24, 2023 10:48
@mx-psi mx-psi requested a review from atoulme October 24, 2023 10:59
@mx-psi mx-psi marked this pull request as ready for review October 24, 2023 10:59
@mx-psi mx-psi requested a review from a team October 24, 2023 10:59
@mx-psi
Copy link
Member Author

mx-psi commented Oct 24, 2023

My proposal is to tag cmd/telemetrygen/v0.88.1 after merging this.

@mx-psi mx-psi merged commit 85fba96 into open-telemetry:main Oct 24, 2023
@github-actions github-actions bot added this to the next release milestone Oct 24, 2023
mx-psi added a commit to mx-psi/opentelemetry-collector-contrib that referenced this pull request Oct 24, 2023
…#28565)

**Description:** open-telemetry#27878 was not enough to fix `go install`, this should
fix it.

**Link to tracking Issue:** Fixes open-telemetry#27855

(cherry picked from commit 85fba96)
codeboten pushed a commit that referenced this pull request Oct 24, 2023
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
…#28565)

**Description:** open-telemetry#27878 was not enough to fix `go install`, this should
fix it.

**Link to tracking Issue:** Fixes open-telemetry#27855
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…#28565)

**Description:** open-telemetry#27878 was not enough to fix `go install`, this should
fix it.

**Link to tracking Issue:** Fixes open-telemetry#27855
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
…#28565)

**Description:** open-telemetry#27878 was not enough to fix `go install`, this should
fix it.

**Link to tracking Issue:** Fixes open-telemetry#27855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/telemetrygen telemetrygen command Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go install doesn't work for telemetrygen
3 participants