[chore] add wastedassign linter #26522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
requested review from
djaglowski,
arminru and
evan-bradley
as code owners
github-actions
bot
added
exporter/dynatrace
receiver/mongodbatlas
receiver/prometheus
atoulme
force-pushed
the
wastedassign_linter
branch
from
0911f3d to
762dedb
Compare
djaglowski
approved these changes
Sep 8, 2023
atoulme
force-pushed
the
wastedassign_linter
branch
from
762dedb to
eebe2d4
Compare
atoulme
force-pushed
the
wastedassign_linter
branch
from
eebe2d4 to
108984d
Compare
atoulme
force-pushed
the
wastedassign_linter
branch
from
108984d to
16a5a53
Compare
sumo-drosiek
approved these changes
Sep 8, 2023
atoulme
force-pushed
the
wastedassign_linter
branch
from
16a5a53 to
4beb1ff
Compare
codeboten
approved these changes
Sep 8, 2023
| clusterNameSet = projectCfg.includesByClusterName | ||
| // exclude is initialized | ||
| case len(exclude) > 0 && len(include) == 0: | ||
| whitelist = false | ||
| allowed = false |
crobert-1
approved these changes
Sep 8, 2023
atoulme
force-pushed
the
wastedassign_linter
branch
from
7f4a30f to
29cb2db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #25060 for original request.
This adds the wastedassign linter with default configuration. It ensures no assignmnent is made to a variable and then not used.