[pkg/stanza] Register missing operators #26453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
reviewed
Sep 5, 2023
There was a problem hiding this comment.
Thanks for the fix @jangaraj.
Although I agree we need to add all parsers and transformers, we have intentionally omitted all input operators because these are presented as receivers. Similarly, we have included only the output operators which have been specifically requested for a use case.
djaglowski
reviewed
Sep 5, 2023
djaglowski
approved these changes
Sep 5, 2023
|
@jangaraj, please add a changelog entry. To do this, run |
djaglowski
changed the title
djaglowski
requested review from
dmitryax,
atoulme,
mx-psi and
songy23
as code owners
github-actions
bot
added
exporter/datadog
github-actions
bot
requested review from
dineshg13,
gbbr,
liustanley,
mackjmr,
pmcollins,
schmikei and
sumo-drosiek
songy23
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Registering missing operators, which may be a causing a problem, when OCB is used and missed operators are used in the OTEL collector config.
Link to tracking Issue: fixes #26452
Testing: NA
Documentation: NA
I'm not sure if input operators make sense. In theory there can be case, where users may need multiple inputs (e.g. syslog, journald) in one receiver, so they probably should be also registered.