Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Update exporter/awscloudwatchlogs README #26375

Merged
merged 5 commits into from
Sep 6, 2023
Merged

[chore] Update exporter/awscloudwatchlogs README #26375

merged 5 commits into from
Sep 6, 2023

Conversation

Danielzolty
Copy link
Contributor

Description:
Recreate #23820 with updates and fixes
Original PR body

Description:
Replaced old example in documentation with a new one. Also clarified some important information for the user, such as the fact that log groups and log streams are created automatically, and that Resource ARNs are not supported. Additionally, updated some descriptions of configs.

Link to tracking Issue: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/4714

Testing: N/A

Documentation:

Added a new example in documentation that shows how to configure the Exporter to send EMF Logs
Clarified that log group and log stream are automatically created for user
Stated Resource ARN isn't supported in the Additional Notes section
Updated some descriptions of configs

@Danielzolty Danielzolty requested review from a team and atoulme September 1, 2023 22:03
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 1, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the exporter/awscloudwatchlogs awscloudwatchlogs exporter label Sep 1, 2023
@bryan-aguilar bryan-aguilar mentioned this pull request Sep 1, 2023
Closed
@bryan-aguilar
Copy link
Contributor

We are working on the getting the CLA approved from our team.

@bryan-aguilar bryan-aguilar mentioned this pull request Sep 5, 2023
Merged
@codeboten codeboten merged commit 4c2f690 into open-telemetry:main Sep 6, 2023
@github-actions github-actions bot added this to the next release milestone Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryan-aguilar bryan-aguilar bryan-aguilar approved these changes

@rapphil rapphil rapphil approved these changes

@codeboten codeboten codeboten approved these changes

@atoulme atoulme Awaiting requested review from atoulme

@boostchicken boostchicken Awaiting requested review from boostchicken

Assignees

@codeboten codeboten

Labels
exporter/awscloudwatchlogs awscloudwatchlogs exporter
Projects
None yet
Milestone
v0.85.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Danielzolty @bryan-aguilar @codeboten @rapphil @ZahidMirza95