-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Upgrade k8s.io/client-go to v0.28.1 #26243
[chore] Upgrade k8s.io/client-go to v0.28.1 #26243
Conversation
There was a breaking change in this upgrade that needed to be handled manually. The fix is to replace usages of ConfigMapsLeasesResourceLock with LeasesResourceLock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crobert-1 are there any release notes or changelog instructions that point us to LeasesResourceLock
with the removal of ConfigMapsLeasesResourceLock
?
The source is the PR introducing the original change: From the PR:
|
To summarize the impact of this change, |
Ty for the summary @jinja2. I've sent this to the rest of the ADOT team and we will take a look at those permissions after these changes are shipped. |
Description:
There was a breaking change in this upgrade that needed to be handled manually. The fix is to replace usages of ConfigMapsLeasesResourceLock with LeasesResourceLock.
To do the deps updates I did the following:
These directories correspond to the two PRs that were closed because of the original issue.
Original PRs: #26010, and #26156.
This doesn't update all packages to use v0.28.1, so let me know if I should update to include all others as well.
Link to tracking Issue:
Fixes #26024
Testing:
Build completes successfully now
Documentation: