Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Upgrade k8s.io/client-go to v0.28.1 #26243

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

crobert-1
Copy link
Member

Description:

There was a breaking change in this upgrade that needed to be handled manually. The fix is to replace usages of ConfigMapsLeasesResourceLock with LeasesResourceLock.

To do the deps updates I did the following:

cd internal/aws/k8s/
go get -u k8s.io/[email protected]
cd ../../kubelet/
go get -u k8s.io/[email protected]

These directories correspond to the two PRs that were closed because of the original issue.
Original PRs: #26010, and #26156.

This doesn't update all packages to use v0.28.1, so let me know if I should update to include all others as well.

Link to tracking Issue:
Fixes #26024

Testing:
Build completes successfully now

Documentation:

There was a breaking change in this upgrade that needed
to be handled manually. The fix is to replace usages of
ConfigMapsLeasesResourceLock with LeasesResourceLock.
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crobert-1 are there any release notes or changelog instructions that point us to LeasesResourceLock with the removal of ConfigMapsLeasesResourceLock?

@crobert-1
Copy link
Member Author

@crobert-1 are there any release notes or changelog instructions that point us to LeasesResourceLock with the removal of ConfigMapsLeasesResourceLock?

The source is the PR introducing the original change:
kubernetes/kubernetes#117558

From the PR:

client-go: the leader election library no longer supports leader-election locks for `endpointsleases` or `configmapsleases` resources. Users of those lock resources should move to `leases` which is safe to do in a single release.```

@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Aug 28, 2023
@jinja2
Copy link
Contributor

jinja2 commented Aug 28, 2023

To summarize the impact of this change, k8s.io/client-go v0.28.0 drops support for using ConfigMapLeases for leader-elections upstream PR. We are switching the receiver which supports leader-election to use only Leases object as opposed to the current behavior of using ConfigMaps and Leases both (which was an intermediary step to make switching from configmap to leases non-breaking). When a user upgrades their daemonset/deployments, the new client will use lease for election, while the old client which has been using both the lease and configmap will still be able to participate. One thing to note though there is no cleanup of the configmap after all clients have been upgraded to use the lease object. The team could potentially drop these permissions later on if interested.

@bryan-aguilar
Copy link
Contributor

Ty for the summary @jinja2. I've sent this to the rest of the ADOT team and we will take a look at those permissions after these changes are shipped.

@dmitryax dmitryax merged commit 110cd54 into open-telemetry:main Aug 28, 2023
@github-actions github-actions bot added this to the next release milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade k8s.io/client-go to 0.28.1
7 participants