[receiver/k8sobjects] Fix issue where resourceVersion was not being remembered, #24806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes an issue where the latest resourceVersion that
RetryWatcher
is remembering is not honored.It turns out that
RetryWatcher
also doesn't like being passed""
or"0"
during startup, and if you pass it a default value of"1"
it will most likely return with a410
complaining that the resource is too old and is long gone.To fix this, we not perform an initial
List
to get the latest values and a proper resourceVersion. This is recommended by https://kubernetes.io/docs/reference/using-api/api-concepts/#efficient-detection-of-changes.Link to tracking Issue:
Closes #24805
Testing:
I tested this a lot manually. I updated the unit tests, but it was a struggle - the fake client framework doesn't honor the resourceVersion concept like k8s actually does.
Documentation:
Updated the readme to call out that Watch mode needs list access if no resource_version is provided.