[receiver/k8scluster] Unify predefined and custom node metrics #24776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
k8scluster-consolidate-custom-node-metrics
branch
4 times, most recently
from
5644527 to
81a1a26
Compare
atoulme
approved these changes
Aug 2, 2023
Update metrics description and units to be consistent and remove predefined metrics definitions from metadata.yaml because they are controlled by `node_conditions_to_report` and `allocatable_types_to_report` config options. Having two controls to enable/disable metrics would be confusing. Potentially, later we could introduce support of metadata.yaml definitions for metrics matching particular globs like `k8s.node.condition_*`
dmitryax
force-pushed
the
k8scluster-consolidate-custom-node-metrics
branch
from
81a1a26 to
a372560
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update node metrics description and units to be consistent and remove predefined metrics definitions from metadata.yaml because they are controlled by
node_conditions_to_reportandallocatable_types_to_reportconfig options. Having two controls to enable/disable metrics would be confusing. Currently, most of the predefined metrics are marked as enabled, but in reality onlyk8s.node.condition_readyis reported by default.Potentially, later we could introduce support of metadata.yaml definitions for metrics matching particular globs like
k8s.node.condition_*or move the variable path of the metric name to an attribute