Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: k8sclusterreceiver allow disabling metrics #24657

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Jul 28, 2023

Description:

Allow enabling / disabling metrics and resource attributes.

Link to tracking Issue:
#24568

Testing:

  • Updated Tests

Documentation:

  • Updated docs

@github-actions github-actions bot requested a review from dmitryax July 28, 2023 12:36
@povilasv povilasv force-pushed the k8sclusterreceiver-enable-disable-metrics branch 6 times, most recently from 1c6691d to bc813c3 Compare July 31, 2023 11:36
@povilasv povilasv force-pushed the k8sclusterreceiver-enable-disable-metrics branch from bc813c3 to 15a8649 Compare July 31, 2023 11:47
@povilasv povilasv marked this pull request as ready for review July 31, 2023 12:17
@povilasv povilasv requested a review from a team July 31, 2023 12:17
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax closed this Jul 31, 2023
@dmitryax dmitryax reopened this Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 64.61% and no project coverage change.

Comparison is base (19f2a53) 82.95% compared to head (15a8649) 82.96%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #24657   +/-   ##
=======================================
  Coverage   82.95%   82.96%           
=======================================
  Files        1633     1633           
  Lines      153880   153959   +79     
=======================================
+ Hits       127653   127727   +74     
- Misses      22754    22758    +4     
- Partials     3473     3474    +1     
Files Changed Coverage Δ
receiver/k8sclusterreceiver/config.go 100.00% <ø> (ø)
...8sclusterreceiver/internal/collection/collector.go 20.20% <0.00%> (-0.21%) ⬇️
...er/k8sclusterreceiver/internal/cronjob/cronjobs.go 50.00% <50.00%> (ø)
receiver/k8sclusterreceiver/internal/hpa/hpa.go 37.50% <50.00%> (ø)
receiver/k8sclusterreceiver/factory.go 100.00% <100.00%> (ø)
...rnal/clusterresourcequota/clusterresourcequotas.go 100.00% <100.00%> (ø)
...k8sclusterreceiver/internal/demonset/daemonsets.go 85.71% <100.00%> (ø)
...clusterreceiver/internal/deployment/deployments.go 84.00% <100.00%> (ø)
receiver/k8sclusterreceiver/internal/jobs/jobs.go 89.18% <100.00%> (ø)
...8sclusterreceiver/internal/namespace/namespaces.go 100.00% <100.00%> (ø)
... and 7 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax merged commit cce00b7 into open-telemetry:main Jul 31, 2023
@github-actions github-actions bot added this to the next release milestone Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants