[cmd/mdatagen] Consolidate resource building workflow #24443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
djaglowski,
codeboten,
atoulme,
dashpole,
MovieStoreGuy,
mx-psi,
Aneurysm9 and
fatsheep9146
as code owners
github-actions
bot
added
cmd/mdatagen
dmitryax
force-pushed
the
mdatagen-with-resource
branch
from
5710ef2 to
f642d84
Compare
dmitryax
force-pushed
the
mdatagen-with-resource
branch
from
f642d84 to
df46db0
Compare
atoulme
reviewed
Jul 24, 2023
dmitryax
changed the title
dmitryax
force-pushed
the
mdatagen-with-resource
branch
from
df46db0 to
99c03d3
Compare
dmitryax
force-pushed
the
mdatagen-with-resource
branch
3 times, most recently
from
eb36415 to
0845f2d
Compare
Use the recently introduce ResourceBuilder in MetricsBuilder instead of generating separate logic. This consolidation will make all the future improvements to the ResourceBuilder applicable for craping receivers and resource processors. This also opens the door for getting away from the sequential ResourceMetrics building using EmitForResource towards better structured map-based approach.
dmitryax
force-pushed
the
mdatagen-with-resource
branch
from
0845f2d to
37f15c9
Compare
djaglowski
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the recently introduced
ResourceBuilderinMetricsBuilderinstead of generating separate logic for resource creation. This consolidation will make all the future improvements to theResourceBuilderapplicable to scraping receivers and resource processors, removing the need to make the same improvements in two places.This also opens the door for getting away from the sequential
ResourceMetricsbuilding usingEmitForResourcetowards a better structured map-based approach. The draft PR including the next steps: #24444