[chore] enable exhaustive option explicit-exhaustive-switch #24412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ziqi Zhao <[email protected]>
67 tasks
|
failed lint check seemed unrelated with this pr |
fatsheep9146
added
the
Skip Changelog
crobert-1
approved these changes
Jul 20, 2023
mx-psi
approved these changes
Jul 21, 2023
Signed-off-by: Ziqi Zhao <[email protected]>
Signed-off-by: Ziqi Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
related #23266
According the suggestion here #23266 (comment)
We should enable exhaustive in a way that makes sure only check for the enum type pmetric.MetricType. So I should do following things
This pr is to enable exhaustive with option explicit-exhaustive-switch