-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd/telemetrygen] Change span kind from an attribute to top level info #24303
[cmd/telemetrygen] Change span kind from an attribute to top level info #24303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this, one change needed
cb7b1de
to
aab0ec3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog and we can get this merged 👍🏻
43edfcb
to
839d963
Compare
Added a chlog entry and rebased, looks like a couple tests fails but seems unrelated to my untrained eyes. |
@edwintye this one does need addressing on this PR:
|
839d963
to
0adf3df
Compare
… level of the span context
0adf3df
to
de64d80
Compare
Description: Remove the span attribute
span.kind
and instead set theKind
(which is a top level span information) directly usingtrace.WithSpanKind
.Link to tracking Issue: #24286
Testing: Added a rudimentary test to ensure that
Kind
is notInternal
which is the default when not specified.Documentation: None. This is probably the original intention.