Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves stanzareceiver into an internal package #2376

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

djaglowski
Copy link
Member

Resolves #2321

> (cd testbed/ && make run-tests-unstable)
TESTS_DIR=tests_unstable_exe ./runtests.sh
=== RUN   TestLog10kDPS
=== RUN   TestLog10kDPS/OTLP
2021/02/18 11:35:57 Starting mock backend...
2021/02/18 11:35:57 Starting Agent (/Users/djaglowski/go/src/github.com/open-telemetry/opentelemetry-collector-contrib/bin/otelcontribcol_unstable_darwin_amd64)
2021/02/18 11:35:57 Writing Agent log to /Users/djaglowski/go/src/github.com/open-telemetry/opentelemetry-collector-contrib/testbed/tests_unstable_exe/results/TestLog10kDPS/OTLP/agent.log
2021/02/18 11:35:57 Agent running, pid=19921
2021/02/18 11:35:58 Starting load generator at 10000 items/sec.
2021/02/18 11:36:00 Agent RAM (RES):   1 MiB, CPU: 0.0% | Sent:     26630 items | Received:    25,400 items (8,463/sec)
2021/02/18 11:36:03 Agent RAM (RES):  44 MiB, CPU:13.3% | Sent:     56649 items | Received:    55,500 items (9,250/sec)
2021/02/18 11:36:06 Agent RAM (RES):  45 MiB, CPU:12.0% | Sent:     86627 items | Received:    85,500 items (9,498/sec)
2021/02/18 11:36:09 Agent RAM (RES):  46 MiB, CPU:12.3% | Sent:    116700 items | Received:   115,600 items (9,633/sec)
2021/02/18 11:36:12 Agent RAM (RES):  47 MiB, CPU:12.7% | Sent:    146700 items | Received:   145,700 items (9,713/sec)
2021/02/18 11:36:13 Stopped generator. Sent:    150000 items
2021/02/18 11:36:13 Gracefully terminating Agent pid=19921, sending SIGTEM...
2021/02/18 11:36:13 Stopping process monitor.
2021/02/18 11:36:13 Agent process stopped, exit code=0
2021/02/18 11:36:13 Sent and received data matches.
2021/02/18 11:36:13 Stopping mock backend...
2021/02/18 11:36:13 Stopped backend. Received:   150,000 items (9,580/sec)
=== RUN   TestLog10kDPS/filelog
2021/02/18 11:36:13 Starting mock backend...
2021/02/18 11:36:13 Starting Agent (/Users/djaglowski/go/src/github.com/open-telemetry/opentelemetry-collector-contrib/bin/otelcontribcol_unstable_darwin_amd64)
2021/02/18 11:36:13 Writing Agent log to /Users/djaglowski/go/src/github.com/open-telemetry/opentelemetry-collector-contrib/testbed/tests_unstable_exe/results/TestLog10kDPS/filelog/agent.log
2021/02/18 11:36:13 Agent running, pid=19956
2021/02/18 11:36:13 Starting load generator at 10000 items/sec.
2021/02/18 11:36:16 Agent RAM (RES):   7 MiB, CPU: 0.0% | Sent:     29900 items | Received:    26,988 items (8,997/sec)
2021/02/18 11:36:19 Agent RAM (RES):  47 MiB, CPU:24.2% | Sent:     59900 items | Received:    56,989 items (9,499/sec)
2021/02/18 11:36:22 Agent RAM (RES):  47 MiB, CPU:24.0% | Sent:     89900 items | Received:    87,203 items (9,689/sec)
2021/02/18 11:36:25 Agent RAM (RES):  47 MiB, CPU:23.3% | Sent:    119900 items | Received:   117,208 items (9,767/sec)
2021/02/18 11:36:28 Agent RAM (RES):  47 MiB, CPU:23.7% | Sent:    149900 items | Received:   147,326 items (9,822/sec)
2021/02/18 11:36:28 Stopped generator. Sent:    150000 items
2021/02/18 11:36:28 Gracefully terminating Agent pid=19956, sending SIGTEM...
2021/02/18 11:36:28 Stopping process monitor.
2021/02/18 11:36:28 Agent process stopped, exit code=0
2021/02/18 11:36:28 Sent and received data matches.
2021/02/18 11:36:28 Stopping mock backend...
2021/02/18 11:36:28 Stopped backend. Received:   150,000 items (9,774/sec)
--- PASS: TestLog10kDPS (31.01s)
    --- PASS: TestLog10kDPS/OTLP (15.66s)
    --- PASS: TestLog10kDPS/filelog (15.35s)
PASS
ok      github.com/open-telemetry/opentelemetry-collector-contrib/testbed/tests_unstable_exe    31.644s
# Test PerformanceResults
Started: Thu, 18 Feb 2021 11:35:57 -0500

Test                                    |Result|Duration|CPU Avg%|CPU Max%|RAM Avg MiB|RAM Max MiB|Sent Items|Received Items|
----------------------------------------|------|-------:|-------:|-------:|----------:|----------:|---------:|-------------:|
Log10kDPS/OTLP                          |PASS  |     16s|    12.5|    13.3|         38|         47|    150000|        150000|
Log10kDPS/filelog                       |PASS  |     15s|    24.1|    24.7|         40|         47|    150000|        150000|

Total duration: 31s

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #2376 (b4c60e7) into main (c519e50) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2376      +/-   ##
==========================================
- Coverage   90.64%   90.63%   -0.01%     
==========================================
  Files         404      404              
  Lines       20031    20031              
==========================================
- Hits        18158    18156       -2     
- Misses       1415     1416       +1     
- Partials      458      459       +1     
Flag Coverage Δ
integration 69.26% <ø> (ø)
unit 89.46% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/stanza/config.go 100.00% <ø> (ø)
internal/stanza/converter.go 100.00% <ø> (ø)
internal/stanza/emitter.go 94.11% <ø> (ø)
internal/stanza/receiver.go 100.00% <ø> (ø)
internal/stanza/factory.go 93.75% <100.00%> (ø)
receiver/filelogreceiver/filelog.go 100.00% <100.00%> (ø)
receiver/k8sclusterreceiver/watcher.go 95.29% <0.00%> (-2.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c519e50...b4c60e7. Read the comment docs.

@djaglowski djaglowski marked this pull request as ready for review February 18, 2021 16:56
@djaglowski djaglowski requested a review from a team February 18, 2021 16:56
.github/CODEOWNERS Show resolved Hide resolved
@tigrannajaryan tigrannajaryan merged commit 28d721d into open-telemetry:main Feb 18, 2021
@djaglowski djaglowski deleted the mv-stanzareceiver branch February 18, 2021 19:16
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move and rename stanzareceiver
3 participants