-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to skip log tokenization #23440
add option to skip log tokenization #23440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how simple this solution is, but I wonder if we're applying it too specifically to the udp input. Should this also be a concern of tcp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haim6678, please sign the CLA
@djaglowski I added a change log file, can you re-approve, please? |
I agree, I thought of this too. TCP input has the same logic so I assume it's suffering from the same issue. I can do it once this PR is merged if you want |
I think the two receivers are related enough that it would be best to keep them in sync. Do you mind adding the tcp changes to this PR? |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating @haim6678. This looks good but I have a few nits.
We also need to document the new parameter in the receiver README and operator README.
@djaglowski can you merge this PR? I'm not authorized. |
@haim6678, please also update the operator readmes |
done |
Description: Performance improvement for UDP receiver.
Currently, UDP created on each log line a scanner object with split functions, even if there was no need for log tokenizing.
this PR adds a new config option 'tokenize_log' (default value set to true) which lets you decide if this is the behavior you want.
if set as false the scanner object is not created and the performance is increased significantly (up to 3X)
Link to tracking Issue: #23237
Testing:
Created a local build of the UDP receiver and tested that the logs arrive and exported as expected.