Fixed typo in Makefile for target 'unit-tests-with-cover' #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Granville Schmidt <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2285 +/- ##
==========================================
+ Coverage 90.69% 90.72% +0.03%
==========================================
Files 399 399
Lines 19802 19802
==========================================
+ Hits 17959 17965 +6
+ Misses 1382 1377 -5
+ Partials 461 460 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jpkrohling
approved these changes
Feb 4, 2021
6 tasks
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
Signed-off-by: Granville Schmidt <[email protected]>
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Fix IPv6 handling errors in semconv.NetAttributesFromHTTPRequest fixes #2283 * Enter PR number in CHANGELOG * Remove unnecessary creation and then assignment Standardize order of checks for IP, Name, Port * Assume happy path when parsing host and port i.e. assume net.SplitHostPort(input) will succeed * Get rid of uint64 for port * Fix git merge of main by adding back strings import Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
hex1848
pushed a commit
to hex1848/opentelemetry-collector-contrib
that referenced
this pull request
Jun 2, 2022
…pen-telemetry#3274) Persistent queue implementation within queued_retry, aimed at being compatible with Jager's [BoundedQueue](https://github.com/jaegertracing/jaeger/blob/master/pkg/queue/bounded_queue.go) interface (providing a simple replacement) and backed by [file storage extension](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/storage/filestorage) for storing WAL. Currently, to run the persistent queue, OpenTelemetry Collector Contrib with `enable_unstable` build tag is required. **Link to tracking Issue:** open-telemetry#2285 [Design doc](https://docs.google.com/document/d/1Y4vNthCGdYI61ezeAzL5dXWgiZ73y9eSjIDitk3zXsU/edit#) **Testing:** Unit Tests and manual testing, more to come **Documentation:** README.md updated, including an example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Granville Schmidt [email protected]
Description:
The Makefile target 'unit-tests-with-cover' has a declaration to mark it phony, but it has the incorrect name of the target to do so.
Link to tracking Issue:
N/A
Testing:
Executed targets via Make and ensured it would always executed without being considered up-to-date.
Documentation:
N/A