Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/schema] use generated status header #22754

Merged
merged 1 commit into from
May 25, 2023

Conversation

codeboten
Copy link
Contributor

This PR updates the component to generate the status table using mdatagen.

Linked issue: #21213

This PR updates the component to generate the status table using mdatagen.

Linked issue: open-telemetry#21213

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten requested a review from a team May 24, 2023 18:49
@codeboten codeboten requested a review from MovieStoreGuy as a code owner May 24, 2023 18:49
@github-actions github-actions bot added the processor/schema Schema processor label May 24, 2023
@codeboten codeboten added Skip Changelog PRs that do not require a CHANGELOG.md entry and removed processor/schema Schema processor labels May 24, 2023
class: processor
stability:
development: [traces, metrics, logs]
distributions: [sumo]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we want to add contrib to the distributions here.

Copy link
Contributor

@atoulme atoulme May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's not listed here: https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml do you mind filing an issue to get it added @crobert-1 ? Thanks!

It's in development so maybe there is a need for another ticket to move it to alpha necessary as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MovieStoreGuy is this component ready to be added to contrib? I got the sense it was still very much under development

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be something of my own confusion. The code for this processor is in contrib, so I assumed that meant it should be listed as one of the distributions. Am I missing something here? Is this something where we don't include in the distribution (even if the code is in contrib) until it meets a certain bar?

@codeboten codeboten merged commit 3f6a263 into open-telemetry:main May 25, 2023
@codeboten codeboten deleted the codeboten/metadata-39 branch May 25, 2023 03:29
@github-actions github-actions bot added this to the next release milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants