Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] [receiver/zipkin] fix configuration docs #22701

Merged
merged 4 commits into from
May 23, 2023
Merged

[chore] [receiver/zipkin] fix configuration docs #22701

merged 4 commits into from
May 23, 2023

Conversation

andrzej-stencel
Copy link
Member

Corrected some invalid docs in README:

  • This receiver does not use gRPC, replaced with HTTP config
  • This receiver does not use queuing, retry and timeout settings from exporterhelper

@andrzej-stencel
[chore] [receiver/zipkin] fix configuration docs
84a9192 
Corrected some invalid docs in README:
- This receiver does not use gRPC, replaced with HTTP config
- This receiver does not use queuing, retry and timeout settings from exporterhelper
@andrzej-stencel andrzej-stencel requested review from a team and Aneurysm9 May 23, 2023 09:15
@github-actions github-actions bot added the receiver/zipkin Zipkin receiver label May 23, 2023
@andrzej-stencel andrzej-stencel mentioned this pull request May 23, 2023
Closed
evan-bradley
evan-bradley reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this.

receiver/zipkinreceiver/README.md Outdated Show resolved Hide resolved
receiver/zipkinreceiver/README.md Show resolved Hide resolved
@dmitryax
Copy link
Member

dmitryax commented May 23, 2023 •
edited
Loading

This receiver does not use queuing, retry and timeout settings from exporterhelper

This is something that we should add. @astencel-sumo could you please create an issue?

UPD: Oh, this is a receiver. Nevermind

@dmitryax dmitryax merged commit 23043df into open-telemetry:main May 23, 2023
@github-actions github-actions bot added this to the next release milestone May 23, 2023
@andrzej-stencel andrzej-stencel deleted the zipkin-receiver-fix-docs branch May 23, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley left review comments

@crobert-1 crobert-1 crobert-1 approved these changes

@dmitryax dmitryax dmitryax approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees

@dmitryax dmitryax

Labels
receiver/zipkin Zipkin receiver
Projects
None yet
Milestone
v0.78.0
Development

Successfully merging this pull request may close these issues.
4 participants
@andrzej-stencel @dmitryax @evan-bradley @crobert-1