-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lokiexporter: Implementation ( PR 2/3 ) #2262
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2262 +/- ##
==========================================
+ Coverage 90.60% 90.62% +0.02%
==========================================
Files 401 402 +1
Lines 19899 19985 +86
==========================================
+ Hits 18029 18111 +82
- Misses 1413 1414 +1
- Partials 457 460 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Happy Tuesday, @kbrockhoff! Hope your week is off to a great start! Do you have a timeframe when you would be able to review this? No rush, just need to ensure that I block out time to respond promptly during the review process. Thank you for all of your help in the Otel community! |
Nice work @gramidt appreciate the effort 👏 We're starting a new repo for easing client integration here https://github.com/grafana/loki-client-go , I'm not saying you should use this, but just wanted to make you aware :) it would simplify your go.mod and how much vendor you have to pull into this repository. How does the log push request batching is working ? Sorry to ask I'm not familiar with open-telemetry log collector. |
@cyriltovena - Thank you so much! I'm so glad to see that a Loki client was split out. This will definitely help with the inevitable dependency issue. I will go ahead and use the protos from 'loki-client-go' now, then submit a future PR with updating the code to use the other pieces of the client where applicable. The OpenTelemetry Collector has the concept of Receivers, Processors, and Exporters. Receivers are responsible for getting data from systems (push or pull), Processors are responsible for processing the data (Batching, Queueing, Sampling, etc), and Exporters are responsible for sending the data off to a another system to either continue processing or storing the data. Here is the list of the "core" processors: https://github.com/open-telemetry/opentelemetry-collector/blob/main/processor/README.md . There are also additional "contrib" processors in this repo. |
Signed-off-by: Granville Schmidt <[email protected]>
…ogic Signed-off-by: Granville Schmidt <[email protected]>
Signed-off-by: Granville Schmidt <[email protected]>
@cyriltovena - After taking another look at the project, I will switch over to 'loki-client-go' for the protos after an official release of it is out. Looking forward to when it's available. :) |
Thank you for all of your help, @kbrockhoff! |
@bogdandrutu - When you're available, could you merge this? |
* added initial loki exporter implementation Signed-off-by: Granville Schmidt <[email protected]> * updated exporter to use consumererrors to enable exporthelper retry logic Signed-off-by: Granville Schmidt <[email protected]> * added memory limiter processor to example Signed-off-by: Granville Schmidt <[email protected]>
…ptracegrpc (#2262) * Bump google.golang.org/grpc in /example/otel-collector Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.40.0 to 1.41.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.40.0...v1.41.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump google.golang.org/grpc in /exporters/otlp/otlpmetric/otlpmetricgrpc Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.40.0 to 1.41.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.40.0...v1.41.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump google.golang.org/grpc in /exporters/otlp/otlptrace/otlptracegrpc Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.40.0 to 1.41.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.40.0...v1.41.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump google.golang.org/grpc in /exporters/otlp/otlpmetric Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.40.0 to 1.41.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.40.0...v1.41.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump google.golang.org/grpc in /exporters/otlp/otlptrace Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.40.0 to 1.41.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.40.0...v1.41.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Auto-fix go.sum changes in dependent modules * go.sum/mod updates Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description:
The implementation of the Loki exporter.
Link to tracking Issue:
#1894
Testing:
Unit Tests
Documentation:
Godoc and README
Notes:
#1952 was the original PR, but we were unable to re-open it after it was closed for being stale.