Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Migrate aerospike receiver to new integration test framework #22141

Merged
merged 3 commits into from
May 22, 2023

Conversation

djaglowski
Copy link
Member

Follows #22104

This test is particularly complicated because of the setup involved. The following notable changes were made:

  • Separate the populateMetrics function into:
    1. A wait strategy which just checks that a client can be created
    2. A post-start hook that populates the system
  • Remove testing.T from populateMetrics, instead returning an error.
    • This is necessary in order to allow container creation to be retryable.

This is the final component using scraperinttest.EqualsLatestMetrics, so allows for removal of that function as well.

@djaglowski djaglowski marked this pull request as ready for review May 22, 2023 16:12
@djaglowski djaglowski requested review from a team and mx-psi May 22, 2023 16:12
@djaglowski djaglowski merged commit d1bda68 into open-telemetry:main May 22, 2023
@djaglowski djaglowski deleted the aerospike-int branch May 22, 2023 16:27
@github-actions github-actions bot added this to the next release milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants