[routingprocessor] Instrument the routing processor with non-routed spans/metric points/log records counters (OTel SDK). #21476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovrus
force-pushed
the
routing-processor/instrument
branch
2 times, most recently
from
dcfafb5 to
738c5c8
Compare
atoulme
changed the title
kovrus
force-pushed
the
routing-processor/instrument
branch
2 times, most recently
from
10f3c24 to
532e557
Compare
mar4uk
reviewed
May 4, 2023
mar4uk
approved these changes
May 4, 2023
|
@jpkrohling can you please take a look at it? |
jpkrohling
reviewed
May 8, 2023
| "go.uber.org/zap" | ||
| ) | ||
|
|
||
| var noopTelemetrySettings = component.TelemetrySettings{ | ||
| TracerProvider: trace.NewNoopTracerProvider(), |
There was a problem hiding this comment.
Do we have a sink that we can use to test whether the data points are being created?
There was a problem hiding this comment.
No, I couldn't find anything like that.
fatsheep9146
approved these changes
May 9, 2023
kovrus
force-pushed
the
routing-processor/instrument
branch
from
a888e1d to
1da23ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Instrument the routing processor with non-routed spans/metric points/log records counters (OTel SDK).
The routing entry key is used as a
routing_keylabel for the metric. It is quite hard to use the value from routing entry as metrics label value, also for the case with OTTL it might simply not be possible. Also, in the future connector implementation of the routing processor we might use only OTTL routing statements.Link to tracking Issue:
Testing:
Documentation: