Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/splunkhec] handle overCapacity error better when we are trying to complete a gzip buffer #20482

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Mar 29, 2023

Description:
Make sure to not return an error if we are over capacity, just return that we cannot accept the event.

Link to tracking Issue:
Fixes #20481

Testing:
Will add tests.

Documentation:

@atoulme atoulme requested a review from a team March 29, 2023 16:27
@atoulme atoulme requested a review from dmitryax as a code owner March 29, 2023 16:27
@runforesight
Copy link

runforesight bot commented Mar 29, 2023

Foresight Summary

    
Major Impacts

TestScraper ❌ failed 1 times in 2 runs (50% fail rate).
TestScraper/cannot_authenticate ❌ failed 1 times in 2 runs (50% fail rate).
TestScraper/invalid_endpoint ❌ failed 1 times in 2 runs (50% fail rate).
TestScraper/metrics_golden ❌ failed 1 times in 2 runs (50% fail rate).
TestScraper/metrics_golden_sftp ❌ failed 1 times in 2 runs (50% fail rate).
build-and-test-windows duration(46 seconds) has decreased 32 minutes 45 seconds compared to main branch avg(33 minutes 31 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 46 seconds (32 minutes 45 seconds less than main branch avg.) and finished at 29th Mar, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 38 seconds and finished at 29th Mar, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 2 minutes 17 seconds (⚠️ 43 seconds more than main branch avg.) and finished at 29th Mar, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 5 minutes 48 seconds and finished at 29th Mar, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  changelog workflow has finished in 5 minutes 6 seconds (⚠️ 2 minutes 53 seconds more than main branch avg.) and finished at 29th Mar, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  load-tests workflow has finished in 17 minutes 19 seconds (⚠️ 6 minutes 34 seconds more than main branch avg.) and finished at 29th Mar, 2023.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 18  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 12 minutes 6 seconds (2 minutes 41 seconds less than main branch avg.) and finished at 29th Mar, 2023.


Job Failed Steps Tests
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details

⭕  build-and-test workflow has finished in 3 minutes 35 seconds (46 minutes 29 seconds less than main branch avg.) and finished at 29th Mar, 2023.


Job Failed Steps Tests
unittest-matrix (1.20, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.20, other) -     🔗  N/A See Details
unittest-matrix (1.19, other) -     🔗  N/A See Details
unittest (1.20) -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter/splunkhec] Do not return error if zip writer is over capacity
4 participants